Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve Windows drive letter URI handling #1816

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Improve Windows drive letter URI handling #1816

merged 2 commits into from
Feb 26, 2025

Conversation

sailingKieler
Copy link
Contributor

  • added additional test cases

@sailingKieler
langium: another refinement in 'uri-utils.ts' specific to the Windows…
ec492d3 
… platform regarding drive letter cases

* added additional test cases
@sailingKieler sailingKieler added this to the v3.4.0 milestone Feb 21, 2025
@sailingKieler sailingKieler requested a review from msujew February 21, 2025 11:08
@msujew msujew changed the title langium: another refinement in 'uri-utils.ts' specific to the Windows platform regarding drive letter cases Improve Windows drive letter URI handling Feb 21, 2025
@sailingKieler sailingKieler force-pushed the cs/uriUtilsDriveLetters branch 2 times, most recently from 0422556 to 189a937 Compare February 21, 2025 14:52
@sailingKieler sailingKieler force-pushed the cs/uriUtilsDriveLetters branch from 189a937 to 02fd044 Compare February 21, 2025 14:53
@sailingKieler sailingKieler requested a review from msujew February 21, 2025 14:56
@sailingKieler
Copy link
Contributor Author

Some tests with string input to UriUtils.relativize(...) should be added.
But today it's enough for me.

msujew
msujew approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me 👍

@msujew msujew merged commit 0e058c7 into main Feb 26, 2025
5 checks passed
@msujew msujew deleted the cs/uriUtilsDriveLetters branch February 26, 2025 12:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@spoenemann spoenemann spoenemann left review comments

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sailingKieler @spoenemann @msujew